[LayoutNG] Text indent with leading float #20096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids breaking after leading floats in the case where
there is a text indentation.
Doing so fixes the following scenario:
<div style="width: 100px; text-indent: 40px;">
<div style="float: left; width: 60px; height: 10px;"></div>
<div style="display: inline-block; width: 60px; height: 20px;"></div>
</div>
In the above example, the following steps will happen:
It does not, and a new line opportunity will be created on the next
line.
can break after. The float can, so it will attempt to rewind.
Not allowing breaks after leading floats in the case of an indentation
fixes the above issue, and appears to match the behavior of other
browsers.
Bug: 1014247
Change-Id: Icf551f5908a0fcb8e0b80a8b9329c965435dd805
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1896509
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#741487}