Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init pghero #72975

Closed
wants to merge 2 commits into from
Closed

Init pghero #72975

wants to merge 2 commits into from

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Nov 7, 2019 •
edited

Motivation for this change

Adds the pghero package, a Ruby webservice that provides a dashboard to view postgresql info and get optimization recommendations and the like.

To be merged after #72967

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @alyssais @zimbatm

craigem
craigem approved these changes Nov 7, 2019
View reviewed changes
Copy link
Contributor

@craigem craigem left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work.

Looking forward to using it.

@manveru manveru closed this Dec 12, 2019
@manveru manveru deleted the init-pghero branch December 12, 2019 17:12
@manveru manveru restored the init-pghero branch December 12, 2019 17:12
@tie tie mentioned this pull request Nov 23, 2023
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craigem craigem craigem approved these changes

@alyssais alyssais Awaiting requested review from alyssais

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: ruby 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manveru @craigem