Recreate #15394 #20146
Recreate #15394 #20146
Conversation
|
There are no reviewers for this pull request besides its author. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you! |
| @@ -25,5 +28,6 @@ | |||
| assert_equals(message.data, orientation, "subframe receives orientation change event"); | |||
There was a problem hiding this comment.
Curious; if this asserts here, what state is the browser left in (we don't reach screen.orientation.unlock() or document.exitFullscreen(), right?)? Could this affect subsequent tests (@foolip ?)
There was a problem hiding this comment.
t.add_cleanup is used in many fullscreen tests and would be a good idea here.
There was a problem hiding this comment.
Should this then try/catch and call t.add_cleanup?
There was a problem hiding this comment.
No try/catch. Add t.add_cleanup as early as possible (right after requesting fullscreen). It will run the cleanup when the test is considered done, regardless of test result.
There was a problem hiding this comment.
I didn't trust bless no to throw :) ... so I put the cleanup at the top of each test. Hope that's ok.
| await test_driver.bless("request fullscreen", () => { | ||
| return document.documentElement.requestFullscreen(); | ||
| }); | ||
| let orientations = [ |
There was a problem hiding this comment.
Apologies, I reformatted this file without realizing.... everything below changed is just prettier doing its thing.
closes #15394
Recreated #15394 because we didn't have write access and it had strange merge conflicts.