Use long timeout in webdriver/tests/find_element_from_element/find.py #20153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…web-platform-tests#20153) * WebKitWebDriver (WebKitGTK) needs at least 55 seconds to run this test. The default timeout (25+5 seconds) is not enough. So use a long timeout (180+5) instead for this wdspec test.
wpt-pr-bot
requested review from
andreastt,
AutomatedTester,
mjzffr,
shs96c and
whimboo
clopez
force-pushed
the
pr-webkitwebdriver-find.py-timeout
branch
from
119faea
to
46bbd35
Compare
andreastt
approved these changes
Nov 8, 2019
|
This is because WebKitGTK was too slow, we have fixed that now and the same test is taking ~4 seconds (see fyi). So I think we can revert this now. |
carlosgcampos
added a commit
to WebKitGTK/web-platform-tests
that referenced
this pull request
Nov 28, 2019
…rom_element/find.py (web-platform-tests#20153) (web-platform-tests#20153)" This reverts commit 2cc5a5c.
andreastt
pushed a commit
that referenced
this pull request
Nov 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WebKitWebDriver (WebKitGTK) needs at least 55 seconds to run this test.
The default timeout (25+5 seconds) is not enough.
So use a long timeout (180+5) instead for this wdspec test.