Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnome2.gnome_vfs: openssl-1.1 patch #72986

Merged
merged 1 commit into from Nov 12, 2019
Merged

gnome2.gnome_vfs: openssl-1.1 patch #72986

merged 1 commit into from Nov 12, 2019

Conversation

oneingan
Copy link
Contributor

@oneingan oneingan commented Nov 7, 2019

Motivation for this change

Get rid of openssl-1.0 for java projects, I'm struggling to package java apps where openssl-1.1 is mandatory. I have override it successfully and think is interesting commit upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @jtojnar

@oneingan
Copy link
Contributor Author

oneingan commented Nov 7, 2019

Sorry about not nix-review. The list of deps is too big for my laptop. Tested openjdk11 and working well.

@jtojnar
Copy link
Contributor

jtojnar commented Nov 7, 2019

Does Java even still need those GNOME 2 dependencies? They have been deprecated for like ten years now.

@oneingan
Copy link
Contributor Author

oneingan commented Nov 7, 2019 •
edited

I guess not, but them are called by openjdk packages when enableGnome2 is true (default).

ping: @edwtjo

@oneingan
Copy link
Contributor Author

Related: #73246

@jtojnar
Copy link
Contributor

jtojnar commented Nov 11, 2019

Could you squash the commits too?

@oneingan
gnome2.gnome_vfs: openssl-1.1 patch
8ea52df 
Use fetchpatch and explain the issue
@FRidh FRidh added this to Needs review in Staging Nov 12, 2019
@globin globin merged commit bfe6cb0 into NixOS:staging Nov 12, 2019
Staging automation moved this from Needs review to Done Nov 12, 2019
@oneingan oneingan deleted the gnome_vfs_openssl11 branch November 12, 2019 22:31
@oneingan oneingan mentioned this pull request Nov 14, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oneingan @jtojnar @globin