hapistrano: fix broken package #72988
Conversation
|
Sorry, created new PR because previous had many commits. |
There was a problem hiding this comment.
@cptrodolfox Thanks for sending this fix.
Aside from the one comment below, you'll also have to modify the pkgs/development/haskell-modules/configuration-hackage2nix.yaml file to mark hapistrano as non-broken.
Here's a video explaining how to do that:
https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968
| # tests require git | ||
| hapistrano = addBuildTool super.hapistrano pkgs.buildPackages.git; | ||
| # tests require git and zsh | ||
| hapistrano = addBuildTool super.hapistrano [ pkgs.buildPackages.git pkgs.buildPackages.zsh ]; |
There was a problem hiding this comment.
| hapistrano = addBuildTool super.hapistrano [ pkgs.buildPackages.git pkgs.buildPackages.zsh ]; | |
| hapistrano = addBuildTools super.hapistrano [ pkgs.buildPackages.git pkgs.buildPackages.zsh ]; |
This should be addBuildTools instead of addBuildTool.
There was a problem hiding this comment.
Hi @cdepillabout, thank you for the review. I have committed the requested changes. Only one question what is the functional difference between addBuildTool and addBuildTools?
There was a problem hiding this comment.
what is the functional difference between addBuildTool and addBuildTools
addBuildTool is for adding a single build tool, while addBuildTools is for adding a list of multiple build tools.
You may have noticed that they both seem to work in this case, but that is only because stdenv.mkDerivation intelligently handles lists when put into buildTools. (If you read through the code, you should be able to see how using addBuildTools and addBuildTool eventually adds the derivations you've specified to buildTools in pkgs/development/haskell-modules/generic-builder.nix, which is using stdenv.mkDerivation under the hood).
However, we don't want to rely on this functionality. It is possible that in a refactor of pkgs/development/haskell-modules/generic-builder.nix, this stops working.
There was a problem hiding this comment.
Thanks, I will keep it in mind for the future.
|
I've confirmed that this builds, so I'll merge in when CI finishes. @cptrodolfox Thanks! This should be available in |
Motivation for this change
Fix haspitrano broken package, the package was failing when building in the test phase.
Things done
Added build packages git and zsh, to the configuration-nix.nix
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @