Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix-synapse: 1.5.0 -> 1.5.1 #72885

Merged
merged 1 commit into from Nov 6, 2019
Merged

matrix-synapse: 1.5.0 -> 1.5.1 #72885

merged 1 commit into from Nov 6, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 6, 2019 •
edited

Motivation for this change

https://github.com/matrix-org/synapse/releases/tag/v1.5.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 6, 2019
@Ma27 Ma27 requested review from Ekleog and pacien November 6, 2019 12:06
@ofborg ofborg bot requested a review from Ralith November 6, 2019 12:23
@pacien
Copy link
Contributor

pacien commented Nov 6, 2019

@ofborg test matrix-synapse

pacien
pacien approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@pacien pacien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Ekleog Ekleog merged commit a1a4484 into NixOS:master Nov 6, 2019
@Ma27 Ma27 deleted the bump-matrix-synapse branch November 6, 2019 13:25
@Ma27
Copy link
Member Author

Ma27 commented Nov 6, 2019

@Ekleog do you also want to backport this? %)

@pacien
Copy link
Contributor

pacien commented Nov 6, 2019

This might qualify as a security update as it's supposed to prevent a DoS attack.

@Ekleog
Copy link
Member

Ekleog commented Nov 6, 2019

Sounds like it'd make sense to me, especially as IIRC releases are already on 1.5.0 :)

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Nov 6, 2019
@Ekleog @dtzWill
Merge pull request NixOS#72885 from Ma27/bump-matrix-synapse
be6f43a 
matrix-synapse: 1.5.0 -> 1.5.1
(cherry picked from commit a1a4484)
@mguentner
Copy link
Contributor

Still needs a backport, right?

@Ma27
Copy link
Member Author

Ma27 commented Nov 13, 2019

Ouch forgot about that. Do you want to do this? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacien pacien pacien approved these changes

@Ekleog Ekleog Awaiting requested review from Ekleog

@Ralith Ralith Awaiting requested review from Ralith

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @pacien @Ekleog @mguentner