Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: 1.24.3 -> 1.25.0 #72892

Merged
merged 2 commits into from Nov 8, 2019
Merged

grpc: 1.24.3 -> 1.25.0 #72892

merged 2 commits into from Nov 8, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Nov 6, 2019

Motivation for this change

Changelog: https://github.com/grpc/grpc/releases/tag/v1.25.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@marsam
Copy link
Contributor Author

marsam commented Nov 6, 2019

@GrahamcOfBorg build pythonPackages.grpcio python3Packages.grpcio

@marsam
Copy link
Contributor Author

marsam commented Nov 6, 2019

@lopsided98 would you mind checking if this release fixes #67808?

@ofborg ofborg bot requested review from LnL7 and vanschelven November 6, 2019 12:49
@lopsided98
Copy link
Contributor

Yes, it fixes pythonPackages.grpcio-tools on armv6l, but grpc fails due to the same issue, but that started happening with the update to 1.24.3, so that shouldn't block this PR. I will try to fix it upstream when I get a chance.

@lopsided98 lopsided98 mentioned this pull request Nov 7, 2019
Closed
10 tasks
@marsam marsam merged commit 311a470 into NixOS:master Nov 8, 2019
@marsam marsam deleted the update-grpc branch November 8, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@vanschelven vanschelven Awaiting requested review from vanschelven

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @lopsided98