Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paraview: 5.6.0 -> 5.6.3 (and fix it) #72891

Merged
merged 1 commit into from Nov 6, 2019

Conversation

JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented Nov 6, 2019

Motivation for this change

Would fail with

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""
This application failed to start because no Qt platform plugin could be initialized. Reinstalling the application may fix this problem.

Aborted (core dumped)

Future todo: Remove the vendored vtk and use the one in nixpkgs. Otherwise 95% of the build time is spent on building vtk. (Or maybe extract their vtk into its own derivation, if it's too heavily forked)

Things done

I have no idea how to use it, but now it starts at least.
image

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @guserav @dguibert @acowley @SFrijters

* Use qt wrapper, otherwise it wouldn't find plugins and fail to start
Copy link
Member

@dguibert dguibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dguibert dguibert merged commit d8e7f7e into NixOS:master Nov 6, 2019
@JohnAZoidberg JohnAZoidberg deleted the fix-qt-paraview branch November 6, 2019 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants