Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manim: init at 0.1.10 #72886

Merged
merged 1 commit into from Feb 10, 2020
Merged

manim: init at 0.1.10 #72886

merged 1 commit into from Feb 10, 2020

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

#60284

cc @ajs124 @matthew-piziak

Please try to use it. Should I add some documentation, to make clear, that it can only be run with manim example.py FooScene and not python -m manim example.py FooScene? (I'm not even sure if the latter works upstream, but they've got it in some documentation).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member Author

Any thoughts @ajs124 @matthew-piziak ?

@matthew-piziak
Copy link
Contributor

How do I build this in a shell again? I got error: cannot auto-call a function that has an argument without a default value ('lib').

@veprbl
Copy link
Member

veprbl commented Nov 15, 2019

@matthew-piziak try:

nix-shell -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/20df42503d673eed8284dbb7f146a81dd8c82551.tar.gz -p manim

@JohnAZoidberg JohnAZoidberg merged commit f10e240 into NixOS:master Feb 10, 2020
@JohnAZoidberg JohnAZoidberg deleted the manim branch February 10, 2020 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohnAZoidberg @matthew-piziak @veprbl