Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/networkd: Add more valid values for RequiredForOnline #72888

Merged
merged 1 commit into from Dec 6, 2019
Merged

nixos/networkd: Add more valid values for RequiredForOnline #72888

merged 1 commit into from Dec 6, 2019

Conversation

fooker
Copy link
Contributor

@fooker fooker commented Nov 6, 2019

RequiredForOnline allows for a boolean value or operational state.
This adds the values for all valid the operational states.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fooker
nixos/networkd: Add more valid values for RequiredForOnline
0aeaf4d 
`RequiredForOnline` allows for a boolean value or operational state.
This adds the values for all valid the operational states.
@Ma27 Ma27 merged commit 4324419 into NixOS:master Dec 6, 2019
@Ma27
Copy link
Member

Ma27 commented Dec 6, 2019

Thanks! Backported as 131ff6d.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Dec 6, 2019
@fooker fooker deleted the pr-3 branch January 30, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fooker @Ma27