nixos/cassandra: Port test to python #72897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg test cassandra |
mmahut
reviewed
Nov 7, 2019
nixos/tests/cassandra.nix
Outdated
| name = "cassandra"; | ||
| meta = { | ||
| maintainers = with lib.maintainers; [ johnazoidberg ]; | ||
| } |
worldofpeace
reviewed
Nov 7, 2019
nixos/tests/cassandra.nix
Outdated
| @@ -9,13 +9,16 @@ let | |||
| jmxRolesFile = ./cassandra-jmx-roles; | |||
| jmxAuthArgs = "-u ${(builtins.elemAt jmxRoles 0).username} -pw ${(builtins.elemAt jmxRoles 0).password}"; | |||
| jmxPort = 7200; # Non-standard port so it doesn't accidentally work | |||
| jmxPortS = toString jmxPort; | |||
There was a problem hiding this comment.
is this like jmx ports? the case like PortS seems incorrect.
There was a problem hiding this comment.
Yeah okay, I changed it to jmxPortStr. That should be clearer :)
JohnAZoidberg
force-pushed
the
python-port-cassandra-test
branch
from
2b3cadd
to
25c2506
Compare
|
@GrahamcOfBorg test cassandra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Things done
nix-build nixos/tests/cassandra.nixprintsNotify maintainers
cc myself