Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More gnome installed test cleanup #72979

Merged

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

Forgot about the tests.installedTests attrs in passthru.
Weird that eval doesn't catch this, I would have probably noticed then.

Also port libgdata 9b99912. Conflicts #72525? Let's merge that PR first.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added the 6.topic: nixos label Nov 7, 2019
@worldofpeace worldofpeace merged commit 65b2a76 into NixOS:master Nov 7, 2019
@worldofpeace worldofpeace deleted the more-gnome-installed-test-cleanup branch November 7, 2019 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants