Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: test display and box-sizing UA style for form controls #20148

Merged
merged 1 commit into from Sep 16, 2021

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Nov 7, 2019

@zcorpan
Copy link
Member Author

zcorpan commented Nov 7, 2019

This tests these parts of the spec change:

box-sizing was added because it was tested in button-style.html (that test is now removed).

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable. I'm assuming you've run this across browsers and filed bugs as needed.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 8, 2019

I'll file browser bugs when whatwg/html#4840 is closer to ready to merge.

Edit: this was done, see OP in whatwg/html#4840

@zcorpan zcorpan assigned zcorpan and unassigned annevk Nov 8, 2019
@zcorpan zcorpan force-pushed the zcorpan/input-display-inline-block branch from d4d34b2 to a007bd2 Compare November 19, 2019 00:00
@gsnedders gsnedders closed this Jan 24, 2020
@gsnedders gsnedders deleted the zcorpan/input-display-inline-block branch January 24, 2020 18:08
@gsnedders gsnedders restored the zcorpan/input-display-inline-block branch January 24, 2020 18:45
@Hexcles Hexcles reopened this Jan 24, 2020
@zcorpan zcorpan removed their assignment Jan 27, 2020
@josepharhar
Copy link
Contributor

Any reason this hasn't been merged yet?

@josepharhar
Copy link
Contributor

Oh, I see it's probably because whatwg/html#4840 hasn't been merged yet

@zcorpan
Copy link
Member Author

zcorpan commented Apr 9, 2021

@josepharhar yeah, I'll hopefully get to work a bit on 'appearance' again soon to finish 4840. We could land this earlier, though this commit has not yet been reviewed: 0d6bde6

@zcorpan
Copy link
Member Author

zcorpan commented Sep 16, 2021

I've rebased this, and the spec change seems ready to merge. Let's merge!

@zcorpan zcorpan merged commit ababf6c into master Sep 16, 2021
@zcorpan zcorpan deleted the zcorpan/input-display-inline-block branch September 16, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants