Fix allowUnfreePredicate example following the introduction of pname. #72981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veprbl
reviewed
Nov 7, 2019
…name Co-Authored-By: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Zimmi48
force-pushed
the
fix-doc-allowUnfreePredicate
branch
from
690c93f
to
b9ac365
Compare
|
Thanks for the suggestion @veprbl! Updated. |
|
Tip: if the PR needs a "motivation for this change" section, so does the commit message. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The introduction of
pname(makingnameoptional) apparently broke the example code provided in the documentation (tested with packageskypewhich only defines apnameand noname). This change fixes it. Note that if specifying apnamebecame compulsory, we could further simplify the example.