Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grass: fix mysql_config query #72874

Merged
merged 1 commit into from Dec 8, 2019
Merged

grass: fix mysql_config query #72874

merged 1 commit into from Dec 8, 2019

Conversation

Izorkin
Copy link
Contributor

@Izorkin Izorkin commented Nov 6, 2019

Motivation for this change

Fix this error:

checking whether to use MySQL... yes
checking for location of MySQL includes... /nix/store/550i6lsdrdrank2kxq8xnv5njsxl4qf6-mariadb-connector-c-3.1.4/include/mysql
checking for mysql.h... yes
checking for location of MySQL library... /nix/store/550i6lsdrdrank2kxq8xnv5njsxl4qf6-mariadb-connector-c-3.1.4/lib/mysql
checking for mysql_query in -lmysqlclient... yes
checking for mysql_config... /nix/store/550i6lsdrdrank2kxq8xnv5njsxl4qf6-mariadb-connector-c-3.1.4/bin/mysql_config
/nix/store/550i6lsdrdrank2kxq8xnv5njsxl4qf6-mariadb-connector-c-3.1.4/bin/mysql_config: unrecognized option '--libmysqld-libs'
checking for mysql_server_init... no
configure: warning: libmysqld not found

Partial correction this issue - #72772
Please backport to 19.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Izorkin
Copy link
Contributor Author

Izorkin commented Nov 6, 2019

@GrahamcOfBorg build grass

@JohnAZoidberg
Copy link
Member

cc Maintainer @mpickering

@mpickering
Copy link
Contributor

I'm not that familiar with grass so I can't comment about why this fixes the build but it looks harmless.

Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lassulus Lassulus merged commit 154f6f1 into NixOS:master Dec 8, 2019
@Izorkin Izorkin deleted the grass-fix1 branch December 8, 2019 10:10
@Izorkin
Copy link
Contributor Author

Izorkin commented Dec 8, 2019

@Lassulus please backport to 19.09.

@Lassulus
Copy link
Member

Lassulus commented Dec 8, 2019

backported in 4c9e6f8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants