ReadableStream: test pipe options exceptions #20143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Nov 7, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1903169
branch
from
a2926d5
to
5ee01fc
Compare
Coverage indicated that the case where there is an exception looking up a pipeTo or pipeThrough option was not actually tested. Add a web platform test to verify that exceptions are thrown and that options are accessed in the correct order. Change-Id: I88d889a42853ee0625cc51fe30cd119b118289b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903169 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#713362}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1903169
branch
from
5ee01fc
to
3038991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coverage indicated that the case where there is an exception looking up
a pipeTo or pipeThrough option was not actually tested. Add a web
platform test to verify that exceptions are thrown and that options are
accessed in the correct order.
Change-Id: I88d889a42853ee0625cc51fe30cd119b118289b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903169
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Adam Rice <ricea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713362}