Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim_configurable: Add vi symlink to vim #72911

Merged
merged 1 commit into from Nov 19, 2019
Merged

vim_configurable: Add vi symlink to vim #72911

merged 1 commit into from Nov 19, 2019

Conversation

JohnAZoidberg
Copy link
Member

Motivation for this change

Like our regular vim, this version should have the vi symlink, so that tools starting vi will not fail but start vim.

Moved preInstall before postInstall because of logic and temporal ordering.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lovek323

@ofborg ofborg bot added the 6.topic: vim label Nov 6, 2019
@ofborg ofborg bot requested a review from lovek323 November 6, 2019 17:38
@d-goldin
Copy link
Contributor

Briefly tested. LGTM.

Lassulus
Lassulus approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lassulus Lassulus merged commit 3de2aeb into NixOS:master Nov 19, 2019
@JohnAZoidberg JohnAZoidberg deleted the vi-configurable branch November 19, 2019 21:06
@JohnAZoidberg
Copy link
Member Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: vim 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohnAZoidberg @d-goldin @Lassulus