Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protontricks: 1.2.5 -> 1.3 #72912

Merged
merged 1 commit into from Nov 7, 2019
Merged

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Nov 6, 2019

Motivation for this change

Upgrade protontricks to 1.3 (https://github.com/Matoking/protontricks/releases/tag/1.3)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JohnAZoidberg
Copy link
Member

Did you try it with a game?

@kira-bruneau
Copy link
Contributor Author

kira-bruneau commented Nov 7, 2019

@JohnAZoidberg I verified that protontricks picked up my existing patches for Just Cause 2. But I'll reset the wine prefix to verify that applying the patches still works.

@kira-bruneau
Copy link
Contributor Author

@JohnAZoidberg Tested protontricks 8190 d3dcompiler_43 d3dx10 on a clean wine prefix and everything works as expected.

Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! :)

@aanderse aanderse merged commit a627c29 into NixOS:master Nov 7, 2019
@aanderse
Copy link
Member

aanderse commented Nov 7, 2019

Thanks team! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants