Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sndpeek: init at 1.4 #69833

Merged
merged 2 commits into from
Sep 29, 2019
Merged

sndpeek: init at 1.4 #69833

merged 2 commits into from
Sep 29, 2019
+76 −0

Conversation

laikq
Copy link
Contributor

@laikq laikq commented Sep 28, 2019 •
edited
Loading

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@laikq laikq changed the base branch from master to release-19.03 September 28, 2019 12:05
@ofborg ofborg bot added 6.topic: emacs Text editor 6.topic: erlang 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby labels Sep 28, 2019
@ofborg ofborg bot removed 6.topic: emacs Text editor 6.topic: erlang 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: golang 6.topic: haskell 6.topic: lua 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 6.topic: policy discussion 6.topic: printing 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 6.topic: stdenv Standard environment 6.topic: steam Steam game store/launcher (store.steampowered.com) 6.topic: vim 6.topic: xfce The Xfce Desktop Environment 8.has: changelog 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Sep 29, 2019
@laikq
Copy link
Contributor Author

laikq commented Sep 29, 2019

Ahoy, I hope this does the trick -- I'm very much a newbie, this is my first pull request to a larger project and I hope I can contribute something and learn more about how this project works.

@laikq
sndpeek: init at 1.4
3215d93 
This version compiles with ALSA, although other modes of compilation could be
imagined.
Lassulus
Lassulus approved these changes Sep 29, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, seems to work

@Lassulus Lassulus merged commit 3090b90 into NixOS:master Sep 29, 2019
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut

@Lassulus Lassulus

@adisbladis adisbladis

@alyssais alyssais

@basvandijk basvandijk

@edolstra edolstra

@edwtjo edwtjo

@Ericson2314 Ericson2314

@FRidh FRidh

@infinisil infinisil

@joachifm joachifm

@matthewbauer matthewbauer

@nbp nbp

@peti peti

@Profpatsch Profpatsch

@thoughtpolice thoughtpolice

@ttuegel ttuegel

@zimbatm zimbatm

@rycee rycee

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@laikq @mmahut @Lassulus @Janik-Haag