Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newsboat: 2.16.1 -> 2.17.1 #69634

Merged
merged 1 commit into from Oct 13, 2019
Merged

newsboat: 2.16.1 -> 2.17.1 #69634

merged 1 commit into from Oct 13, 2019

Conversation

sikmir
Copy link
Member

@sikmir sikmir commented Sep 27, 2019 •
edited

Motivation for this change

CHANGELOG

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
$ nix path-info -Sh /nix/store/y0cq1ym29a4lwn72r9ylia31xppsviv4-newsboat-2.16.1
/nix/store/y0cq1ym29a4lwn72r9ylia31xppsviv4-newsboat-2.16.1	  84.0M
$ nix path-info -Sh /nix/store/yf82cazi7jhfp7baqq58xchmzqmq647h-newsboat-2.17.1
/nix/store/yf82cazi7jhfp7baqq58xchmzqmq647h-newsboat-2.17.1	  84.8M
Notify maintainers

cc @dotlambda, @nicknovitski, @dywedir

@ofborg ofborg bot requested a review from dotlambda September 27, 2019 07:24
@Minoru
Copy link
Contributor

Minoru commented Sep 27, 2019

Hi! Newsboat maintainer here. Thanks for packaging it! Yet, you might want to hold off the merge for a few days, because I'll release 2.17.1 on Saturday or Sunday—turns out there are two critical bugs that render Newsboat unusable for some people.

@sikmir sikmir changed the title newsboat: 2.16.1 -> 2.17 newsboat: 2.16.1 -> 2.17.1 Oct 4, 2019
@sikmir
Copy link
Member Author

sikmir commented Oct 4, 2019

Updated to 2.17.1

@dywedir
Copy link
Member

dywedir commented Oct 13, 2019

@GrahamcOfBorg build newsboat

@dywedir
Copy link
Member

dywedir commented Oct 13, 2019

Thanks!

@dywedir dywedir merged commit 9666f3c into NixOS:master Oct 13, 2019
@sikmir sikmir deleted the newsboat branch October 13, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sikmir @Minoru @dywedir