Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-fonts] Parse font-optical-sizing and font-language-override #19384

Merged
merged 2 commits into from Oct 13, 2019
Merged

[css-fonts] Parse font-optical-sizing and font-language-override #19384

merged 2 commits into from Oct 13, 2019

Conversation

ewilligers
Copy link
Contributor

@ewilligers ewilligers commented Sep 28, 2019 •
edited

Test valid and invalid values for font-optical-sizing and font-language-override
https://drafts.csswg.org/css-fonts-4/#property-index

@ericwilligers
[css-fonts] Skip unimplemented properties
bce1662 
Test only font-language-override and
font-optical-sizing.
@ewilligers ewilligers changed the title CSS Fonts 4 parsing [css-fonts] Parse font-optical-sizing and font-language-override Sep 28, 2019
@ewilligers
Copy link
Contributor Author

@litherum please review

@ewilligers
Copy link
Contributor Author

@BorisChiou please review

BorisChiou
BorisChiou approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@BorisChiou BorisChiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me.

@ewilligers ewilligers merged commit 59a4941 into web-platform-tests:master Oct 13, 2019
@ewilligers ewilligers deleted the font-4 branch October 13, 2019 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BorisChiou BorisChiou BorisChiou approved these changes

@drott drott Awaiting requested review from drott

@litherum litherum Awaiting requested review from litherum

@svgeesus svgeesus Awaiting requested review from svgeesus

Assignees

@litherum litherum

Labels
css-fonts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ewilligers @BorisChiou @litherum @ericwilligers