Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: 0.8.1 -> 0.8.2 #69647

Merged
merged 1 commit into from Sep 27, 2019
Merged

zfs: 0.8.1 -> 0.8.2 #69647

merged 1 commit into from Sep 27, 2019

Conversation

Baughn
Copy link
Contributor

@Baughn Baughn commented Sep 27, 2019

Motivation for this change

Now also works with Linux 5.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @jcumming @wizeman @fpletz @globin

@fpletz fpletz added this to the 19.09 milestone Sep 27, 2019
@fpletz fpletz added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 27, 2019
@fpletz
Copy link
Member

fpletz commented Sep 27, 2019

@GrahamcOfBorg build zfs linuxPackages.zfs linuxPackages_latest.zfs

@fpletz
Copy link
Member

fpletz commented Sep 27, 2019

Ran the zfs test locally. 👍

@fpletz fpletz merged commit 1bcd6fd into NixOS:master Sep 27, 2019
@Mic92 Mic92 mentioned this pull request Oct 1, 2019
Closed
10 tasks
@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
19.09
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Baughn @fpletz @TredwellGit