Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

units: Add units_cur python script to $out #69843

Merged
merged 1 commit into from
Nov 7, 2019
Merged

units: Add units_cur python script to $out #69843

merged 1 commit into from
Nov 7, 2019
+30 −3

Conversation

doronbehar
Copy link
Contributor

Motivation for this change

The GNU package units provides a Python script named units_cur which is not installed by default using make install. This change adds that file to the package's $out. It is possible to configure the pythonPackages set which will be used for the only Python dependency which is requests.

Things done

I've changed the default units package to include the Python script by default in pkgs/top-level/all-packages.nix because I think that's the author's intention.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @vrthra

Sorry, something went wrong.

@ofborg ofborg bot requested a review from vrthra September 28, 2019 13:40
@doronbehar doronbehar mentioned this pull request Oct 3, 2019
Merged
10 tasks
@bjornfor
Copy link
Contributor

bjornfor commented Oct 6, 2019

Have you talked to upstream about why this script isn't installed by them?

@doronbehar
Copy link
Contributor Author

AFAIK, upstream doesn't have a bug reports webpage or a GitHub repo or anything like that, they don't even use a VCS. I once talked with the developer directly through with email and he was responsive but I don't think this issue is such a big deal that we should send him a patch making Makefile.am install this script.

I wouldn't mind that much doing it but I'm not experienced with GNU autotools so I don't think it's worth the effort.

@matthewbauer matthewbauer merged commit ba20555 into NixOS:master Nov 7, 2019
@doronbehar doronbehar deleted the units_cur branch March 2, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrthra vrthra

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@doronbehar @bjornfor @matthewbauer