Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calibre: 3.47.1 -> 3.48.0 #69837

Merged
merged 1 commit into from Oct 26, 2019
Merged

calibre: 3.47.1 -> 3.48.0 #69837

merged 1 commit into from Oct 26, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

Regular update. html2text was missing on the old version as well. Also tidied up a few things to make it easier to test out with py3 which is WIP upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @domenkozar @pSub @AndersonTorres

}:

let
pypkgs = python2Packages;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would probably take pythonPackages as a parameter, and just set it explicitly in all-packages.nix. Would also make it a lot easier to override

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I got this failure:

builder for '/nix/store/ijs8ng5xc14dc7jl0sbqbfqm8nv8i3l1-librsvg-2.44.15.drv' failed with exit code 2; last 10 log lines:

  For more information about this error, try `rustc --explain E0506`.
  error: Could not compile `cssparser`.

  To learn more, run the command again with --verbose.
  make[2]: *** [Makefile:1934: /build/librsvg-2.44.15/target/release/librsvg_internals.a] Error 101
  make[2]: Leaving directory '/build/librsvg-2.44.15'
  make[1]: *** [Makefile:1438: all-recursive] Error 1
  make[1]: Leaving directory '/build/librsvg-2.44.15'
  make: *** [Makefile:931: all] Error 2
cannot build derivation '/nix/store/3hrnsjg6ly2p7sy8mbqdnxznrfgm20lc-djvulibre-3.5.27.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2xgz2afir4cispwgmlhbzqs6aqj5i1v4-imagemagick-6.9.9-34.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/4q1g02wqiakclmpbcih5k037gp3xlzxd-calibre-3.48.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5w32bnvqyhkxdd7wrwwrfwm42f1wsna4-env.drv': 1 dependencies couldn't be built
[3 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/5w32bnvqyhkxdd7wrwwrfwm42f1wsna4-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/69837
1 package failed to build:
calibre

Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, started calibre, finished the wizard, converted a book

@Lassulus Lassulus merged commit e93d045 into NixOS:master Oct 26, 2019
@peterhoeg peterhoeg deleted the u/calibre branch September 7, 2020 04:44
@peterhoeg peterhoeg restored the u/calibre branch October 6, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants