Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "busybox: fix musl builds" #70023

Merged
merged 1 commit into from Sep 29, 2019
Merged

Revert "busybox: fix musl builds" #70023

merged 1 commit into from Sep 29, 2019

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 29, 2019 •
edited

This reverts commit 5ba8c04.

Broke busybox used in nix.

fixes: #70007

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
Revert "busybox: fix musl builds"
64d821d 
This reverts commit 5ba8c04.

Broke non-musl busybox.

fixes: NixOS#70007
@Mic92
Copy link
Member Author

Mic92 commented Sep 29, 2019

@GrahamcOfBorg build nix

@Mic92 Mic92 merged commit a702db7 into NixOS:master Sep 29, 2019
@Mic92 Mic92 deleted the busybox branch September 29, 2019 14:36
@Mic92 Mic92 mentioned this pull request Sep 29, 2019
Merged
10 tasks
vcunat referenced this pull request Oct 12, 2019
@domenkozar
busybox: remove the missing diff
5ea4c91
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Busybox no longer builds
1 participant
@Mic92