Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nvidia-x11: Remove patches from the 390 version. #69851

Merged
merged 1 commit into from Sep 28, 2019
Merged

nvidia-x11: Remove patches from the 390 version. #69851

merged 1 commit into from Sep 28, 2019

Conversation

ambrop72
Copy link
Contributor

Without those patches it builds and works with kernels 4.19 and 5.2.

Fixes #65937

Motivation for this change

These patches do not apply and are not needed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @eadwu

@ambrop72
nvidia-x11: Remove patches from the 390 version.
3aaecd2 
Without those patches it builds and works with kernels 4.19 and 5.2.

Fixes NixOS#65937
@veprbl veprbl merged commit b1ed9c6 into NixOS:master Sep 28, 2019
@ambrop72 ambrop72 mentioned this pull request Oct 5, 2019
Closed
10 tasks
vcunat pushed a commit that referenced this pull request Oct 12, 2019
@ambrop72 @vcunat
nvidia-x11: Remove patches from the 390 version. (#69851)
9ce5780 
Without those patches it builds and works with kernels 4.19 and 5.2.

Fixes #65937

(cherry picked from commit b1ed9c6)
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 1, 2019
@ambrop72 @dtzWill
nvidia-x11: Remove patches from the 390 version. (NixOS#69851)
d6fae3a 
Without those patches it builds and works with kernels 4.19 and 5.2.

Fixes NixOS#65937

(cherry picked from commit b1ed9c6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eadwu eadwu eadwu approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nvidiaLegacy390 fails to build
3 participants
@ambrop72 @eadwu @veprbl