Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.keyring: 19.1.0 -> 19.2.0 #69676

Merged
merged 1 commit into from Oct 2, 2019
Merged

python3Packages.keyring: 19.1.0 -> 19.2.0 #69676

merged 1 commit into from Oct 2, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 27, 2019 •
edited

Motivation for this change

noticed ERROR: Package 'keyring' requires a different Python: 2.7.16 not in '>=3.5' while reviewing another PR of mine.

decided to bump it while disabling python2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[21 built, 94 copied (306.1 MiB), 45.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69676
2 package are marked as broken and were skipped:
backintime backintime-qt4

21 package were build:
aws-google-auth backintime-common bonfire coursera-dl gajim i3pystatus jira-cli jrnl ledger-autosync maestral maestral-gui nagstamon pgcli python37Packages.astroquery python37Packages.browser-cookie3 python37Packages.bugwarrior python37Packages.keyring python37Packages.keyrings-alt python37Packages.ofxclient spyder urlwatch

@ofborg ofborg bot requested a review from lovek323 September 27, 2019 18:11
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.keyring

@jonringer
Copy link
Contributor Author

seeing as this fixes a broken build and nix-review passes, im going to merge

 package are marked as broken and were skipped:
backintime backintime-qt4

21 package were build:
aws-google-auth backintime-common bonfire coursera-dl gajim i3pystatus jira-cli jrnl ledger-autosync maestral maestral-gui nagstamon pgcli python37Packages.astroquery python37Packages.browser-cookie3 python37Packages.bugwarrior python37Packages.keyring python37Packages.keyrings-alt python37Packages.ofxclient spyder urlwatch

@jonringer jonringer merged commit 8d440b5 into NixOS:master Oct 2, 2019
@jonringer jonringer deleted the bump-keyring branch February 13, 2020 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@lovek323 lovek323 Awaiting requested review from lovek323

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer