libX11: adds upstream patch to fix cross-compilation #69700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this patch applied, cross-compilation of a system image for ARM platforms works as it did previously. See their commit for more explanation: * https://cgit.freedesktop.org/xorg/lib/libX11/commit/?id=0327c427d62f671eced067c6d9b69f4e216a8cac
samueldr
force-pushed
the
cross/fix/libX11
branch
from
a329611
to
85f97f2
Compare
|
Seeing this commit in 19.09-beta 8d3d7ce. |
|
+1 for a backport to nixos-19.09-staging; this should make 19.09 a known relatively trivial target to cross-compile. |
worldofpeace
approved these changes
Sep 28, 2019
|
hmm, probably should check with ofborg cross compilation. |
vcunat
approved these changes
Sep 28, 2019
vcunat
added a commit
that referenced
this pull request
Sep 28, 2019
(cherry picked from commit 52af1d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch applied, cross-compilation of a system image for ARM
platforms works as it did previously.
See their commit for more explanation:
Motivation for this change
Things done
☑️ Verified that it builds the nixos sd image using this configuration.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @dtzWill author of the upgrade #68072