pass: add patch for basic wayland support #69643
Conversation
This adds an upstream patch to support `wl-clipboard` for `pass -c` and optionally wraps `wl-clipboard`. The patch is directly checked into nixpkgs as it had to be modified to properly apply with `set-correct-name-for-sleep.patch`.
|
@fpletz does it make sense to you to backport this to 19.09? |
|
Does anyone use this with sway? It works for me in a weston window but in sway the password doesn't end up on the clipboard. |
|
Yes I do, for several months now. Do you get any errors from sway or sth. like that? And is your terminal running on wayland or X (a.k.a Xwayland)? |
|
I don’t get any errors. I’ve tried it with termite and weston-terminal and verified pass is using wl-clipboard with WAYLAND_DEBUG=1.
It seems like it’s copying to the wrong clipboard. I’ve been looking at the diff of ‘ WAYLAND_DEBUG=1 pass -c...’ vs ‘ WAYLAND_DEBUG=1 wl-copy ...’ but I don’t understand the log format enough to make any sense of it yet.
|
|
Does it work if you do sth. like |
|
Thanks for the help and sorry for wasting your time. After digging into it again I realized that pass was using wl-clipboard-1.0 whereas I have wl-clipboard-2.0 in my environment. Updating to a commit after wl-clipboard was updated to 2.0 fixes this. So as I was beginning to suspect my issue was caused by incompatibility with the stable channel. This is the first time I've encountered an issue where importing a package from a commit on master yielded older dependencies than are on stable (since wl-clipboard-2.0 was backported) and it's making me question my approach. It seems like programmatically cherry-picking a list of commits to the stable channel before building would avoid such issues (and also streamline the process since one process would patch both modules and packages). I'm not aware of any tooling to do this but it wouldn't take a very big script to implement. |
Motivation for this change
This adds an upstream patch to support
wl-clipboardforpass -candoptionally wraps
wl-clipboard. The patch is directly checked intonixpkgs as it had to be modified to properly apply with
set-correct-name-for-sleep.patch.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @