New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More closure size improvements for NixOS 19.09 #70025
More closure size improvements for NixOS 19.09 #70025
Conversation
pkgs/tools/graphics/zbar/default.nix
Outdated
@@ -17,6 +17,8 @@ in stdenv.mkDerivation rec { | |||
sha256 = "0hlxakpyjg4q9hp7yp3har1n78341b4knwyll28hn48vykg28pza"; | |||
}; | |||
|
|||
outputs = [ "out" "dev" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we actually already went a lot further with this
There's other commits there that clean up dependencies etc. on master that perhaps we can backport.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't aware of that pull request, thanks! I will backport that instead, as I prefer not to diverge from master.
Why was this not relevant for master? This ends up being weird because now we need to fix up eg. kea which broke because of the mariadb change, but only in release-19.09. That's not a divergence I'm used to seeing. |
The relevant parts of this are in master, but the branches had already diverged to the point that I couldn't blindly cherry-pick the changes into the release branch. |
@ttuegel Thanks! I understand what's going on now. :) |
Motivation for this change
These are more closure size improvements for
release-19.09
because they aren't relevant towardmaster
.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @