Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

niv: mark as not broken #69870

Merged
merged 1 commit into from Sep 28, 2019
Merged

niv: mark as not broken #69870

merged 1 commit into from Sep 28, 2019

Conversation

nmattia
Copy link
Contributor

@nmattia nmattia commented Sep 28, 2019

The package used to depend on the "broken" github library. This
dependency was dropped and the package now builds.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@basvandijk @peti is this the right way to unbreak a Haskell package? I followed the instructions here but might have missed something: https://www.youtube.com/watch?v=KLhkAEk8I20

@nmattia
niv: mark as not broken
3867b45 
`niv` used to depend on the broken `github`. The dependency was removed
and `niv` builds fine.
@peti peti merged commit 0ef1b75 into NixOS:haskell-updates Sep 28, 2019
@nmattia nmattia deleted the nm-unbreak-niv branch September 28, 2019 17:51
@flokli
Copy link
Contributor

flokli commented Nov 15, 2019

@nmattia this wasn't backported to the 19.09 branch, right?

@nmattia
Copy link
Contributor Author

nmattia commented Nov 15, 2019

@flokli I ... have no idea.

@flokli
Copy link
Contributor

flokli commented Nov 15, 2019

I assume this was merged in after the branchoff, but before the release, and nobody did "backport" it to 19.09.
I just checked out release-19.09 - it is still marked as broken there. Do you want to give it a try if this PR can just be cherry-pick -x-ed on that branch and unbreaked there, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nmattia @flokli @peti