Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: get rid of msgpack-python, fixes #48864 #69989

Merged
merged 3 commits into from Sep 29, 2019
Merged

python: get rid of msgpack-python, fixes #48864 #69989

merged 3 commits into from Sep 29, 2019

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Sep 29, 2019

We already have msgpack, which is the same. Building a Python env with
spacy resulted in a collision between an .so provided through both
msgpack and msgpack-python.

I don't know why transitional = True was set. These kind of things
should be documented!

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
python: get rid of msgpack-python, fixes NixOS#48864
5f02474 
We already have msgpack, which is the same. Building a Python env with
`spacy` resulted in a collision between an `.so` provided through both
`msgpack` and `msgpack-python`.

I don't know why `transitional = True` was set. These kind of things
should be documented!
@FRidh
pybitmessage: fix build
be19e7a 
- use setuptools
- use msgpack instead of msgpack-python
@FRidh FRidh merged commit 0d956a6 into NixOS:master Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aborsu aborsu Awaiting requested review from aborsu

@costrouc costrouc Awaiting requested review from costrouc

@danieldk danieldk Awaiting requested review from danieldk

@PsyanticY PsyanticY Awaiting requested review from PsyanticY

@jbaum98 jbaum98 Awaiting requested review from jbaum98

@xeji xeji Awaiting requested review from xeji

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FRidh