Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.streamz: 0.5.1 -> 0.5.2 #69681

Merged
merged 1 commit into from Sep 29, 2019
Merged

pythonPackages.streamz: 0.5.1 -> 0.5.2 #69681

merged 1 commit into from Sep 29, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 27, 2019 •
edited

Motivation for this change

noticed it was broken while reviewing another package.

bumped it while fixing it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69681
1 package were build:
python37Packages.streamz

@jonringer jonringer changed the title pythonPacakges.streamz: 0.5.1 -> 0.5.2 pythonPackages.streamz: 0.5.1 -> 0.5.2 Sep 27, 2019
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.streamz python3Packages.streamz

@ofborg ofborg bot requested a review from costrouc September 27, 2019 18:59
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.streamz python3Packages.streamz

@jonringer
Copy link
Contributor Author

@marsam sorry for bothering you, but this could use a merge.

@Ma27 will likely need to be backported to 19.09

@marsam marsam merged commit 20f4f2e into NixOS:master Sep 29, 2019
@marsam
Copy link
Contributor

marsam commented Sep 29, 2019

Thanks @jonringer

@jonringer
Copy link
Contributor Author

I finally got commit access, I just don't like the idea of merging my own commits :)

@jonringer jonringer deleted the bump-streamz branch September 29, 2019 13:03
@marsam
Copy link
Contributor

marsam commented Sep 29, 2019

I finally got commit access

Congrats, we're delighted to have you

I just don't like the idea of merging my own commits :)

same 😅, but please don't hesitate to mention me if you need anything merged

backported in fb2ea4fa6a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @marsam