Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyre: remove #70001

Merged
merged 1 commit into from Oct 4, 2019
Merged

pyre: remove #70001

merged 1 commit into from Oct 4, 2019

Conversation

teh
Copy link
Contributor

@teh teh commented Sep 29, 2019

Every other version update of pyre is non-trivial and requires
specific versions which blocks updates elsewhere. Removing now,
we can re-import when pyre has settled down.

Motivation for this change

I'm having trouble updating this. My feeling is that I want to wait out maybe another year of pyre development and hope that the build system + dependencies have settled down by then.

Unblocks #69932

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Every other version update of pyre is non-trivial and requires
specific versions which blocks updates elsewhere. Removing now,
we can re-import when pyre has settled down.
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, nothing changed, its used nowhere else, you are the maintainer. So should be alright

@Lassulus Lassulus merged commit fa4b518 into NixOS:master Oct 4, 2019
@siraben
Copy link
Member

siraben commented Mar 30, 2021

@teh so over a year has passed, are things upstream stable enough for this to be re-added into Nixpkgs?

@siraben siraben mentioned this pull request Mar 30, 2021
10 tasks
@teh
Copy link
Contributor Author

teh commented Mar 30, 2021

@siraben if you can maintain it please give it a go! We moved to my-py which isn't as fast etc but good enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants