pythonPackages.bleach: add implicit setuptools dependency #70006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 11-100
10.rebuild-linux: 11-100
labels
jonringer
approved these changes
Oct 3, 2019
There was a problem hiding this comment.
nix-review passes on NixOS (4 broken on master)
diff LGTM
fixes original issue
[37 built (4 failed), 196 copied (1955.2 MiB), 494.0 MiB DL]
error: build of '/nix/store/42yn16xxfdjn6dhyrkx7qvqa55vw7dq0-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/70006
2 package are marked as broken and were skipped:
ihaskell python27Packages.spyder
4 package failed to build:
python27Packages.cufflinks python37Packages.cufflinks python37Packages.datashader python37Packages.starfish
64 package were build:
isso jupyter matrix-synapse python27Packages.ansible-kernel python27Packages.bleach python27Packages.colorcet python27Packages.holoviews python27Packages.hvplot python27Packages.ipywidgets python27Packages.jupyter python27Packages.kmapper python27Packages.mezzanine python27Packages.modeled python27Packages.moretools python27Packages.nbconvert python27Packages.nbsmoke python27Packages.nbsphinx python27Packages.notebook python27Packages.readme python27Packages.readme_renderer python27Packages.restview python27Packages.robotframework-tools python27Packages.runway-python python27Packages.twine python27Packages.widgetsnbextension python27Packages.zetup python37Packages.Nikola python37Packages.Pweave python37Packages.ansible-kernel python37Packages.bleach python37Packages.colorcet python37Packages.fints python37Packages.holoviews python37Packages.hvplot python37Packages.intake python37Packages.ipywidgets python37Packages.jupyter python37Packages.jupyterhub python37Packages.jupyterhub-ldapauthenticator python37Packages.jupyterlab python37Packages.jupyterlab_launcher python37Packages.jupyterlab_server python37Packages.kmapper python37Packages.mezzanine python37Packages.modeled python37Packages.moretools python37Packages.nbconvert python37Packages.nbsmoke python37Packages.nbsphinx python37Packages.notebook python37Packages.oauthenticator python37Packages.readme python37Packages.readme_renderer python37Packages.restview python37Packages.robotframework-tools python37Packages.runway-python python37Packages.scikit-tda spyder python37Packages.toggl-cli python37Packages.twine python37Packages.widgetsnbextension python37Packages.zetup sage sageWithDoc
|
@GrahamcOfBorg build python3Packages.bleach pythonPackages.bleach |
jonringer
added
the
9.needs: port to stable
|
backported 014afee |
jonringer
added
8.has: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I've noticed the bleach package uses modules from the setuptools package, which is not explicitly referenced in the setup.py.
Related to #69411.
Things done
Added setuptools to the propagatedBuildInputs.
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @prikhi