Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions.cmschuetz12.wal: init at 0.1.0 #69813

Merged
merged 1 commit into from Oct 2, 2019
Merged

vscode-extensions.cmschuetz12.wal: init at 0.1.0 #69813

merged 1 commit into from Oct 2, 2019

Conversation

feijoas
Copy link
Contributor

@feijoas feijoas commented Sep 28, 2019 •
edited

wal theme generator vscode extension

  • Vscode editor theme based on generated wal colors
  • Automatic updates as wal color/theme changes
  • Syntax highlighting from locally installed themes
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@feijoas feijoas force-pushed the vscode-extensions.cmschuetz12.wal branch from d92324d to c05a4a1 Compare September 30, 2019 15:29
jonringer
jonringer approved these changes Oct 2, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested using:

[21:40:08] jon@jon-desktop /home/jon/projects/nixpkgs ((c05a4a121a4...))
$ nix-shell -p "with import ./. {}; vscode-with-extensions.override { vscodeExtensions = with vscode-extensions; [ cmschuetz12.wal ];}"
...
building '/nix/store/j74qlgcvi02nqnr9lbzbcbyv2vmw3qk8-vscode-with-extensions-1.38.1.drv'...

[nix-shell:/home/jon/projects/nixpkgs]$ code

shows correct extension installed in vscode

@jonringer jonringer merged commit 8358d75 into NixOS:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@feijoas @jonringer @mschneiderwng