Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.james-yu.latex-workshop: init at 8.2.0 #69816

Merged

Conversation

feijoas
Copy link
Contributor

@feijoas feijoas commented Sep 28, 2019

LaTeX Workshop is an extension for Visual Studio Code, aiming to provide core features for LaTeX typesetting with Visual Studio Code. It also has a sibling extension, LaTeX Utilities, providing extra feature

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
pkgs/misc/vscode-extensions/default.nix Outdated Show resolved Hide resolved
@jonringer
Copy link
Contributor

also, it looks like you have commits from your other 2 PRs in here

@feijoas feijoas force-pushed the vscode-extensions.James-Yu.latex-workshop branch from de6e7cc to 3a89f38 Compare September 30, 2019 15:21
@feijoas feijoas force-pushed the vscode-extensions.James-Yu.latex-workshop branch from 3a89f38 to 3fbbab6 Compare September 30, 2019 15:33
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[21:31:04] jon@jon-desktop /home/jon/projects/nixpkgs ((3fbbab6bfd7...))
$ nix-shell -p "with import ./. {}; vscode-with-extensions.override { vscodeExtensions = with vscode-extensions; [ james-yu.latex-workshop];}"
these derivations will be built:
  /nix/store/cwp4xbsn1s2z5ra6qb50h81371p5fpx7-vscode-extensions-1.38.1.drv
  /nix/store/2azknc00vgahxfjkmisb54yqn5ss9v24-vscode-with-extensions-1.38.1.drv
building '/nix/store/cwp4xbsn1s2z5ra6qb50h81371p5fpx7-vscode-extensions-1.38.1.drv'...
created 1 symlinks in user environment
building '/nix/store/2azknc00vgahxfjkmisb54yqn5ss9v24-vscode-with-extensions-1.38.1.drv'...

[nix-shell:/home/jon/projects/nixpkgs]$ code

shows a vscode installation with the latex-workshop installed

@jonringer jonringer merged commit 90fc4a1 into NixOS:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants