Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-extensions.skyapps.fish-vscode init at 0.2.1 #69814

Merged

Conversation

feijoas
Copy link
Contributor

@feijoas feijoas commented Sep 28, 2019

Fish syntax highlighting for VS Code vscode extension

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@feijoas feijoas closed this Sep 28, 2019
@feijoas feijoas reopened this Sep 28, 2019
@feijoas feijoas changed the title Vscode extensions.skyapps.fish vscode vscode-extensions.skyapps.fish-vscode init at 0.2.1 Sep 28, 2019
@jonringer
Copy link
Contributor

you have commits from #69813 in here :)

@feijoas feijoas force-pushed the vscode-extensions.skyapps.fish-vscode branch from 3ab3796 to 3bb2b3f Compare September 30, 2019 15:25
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested using:

[21:35:44] jon@jon-desktop /home/jon/projects/nixpkgs ((3bb2b3f8d39...))
$ nix-shell -p "with import ./. {}; vscode-with-extensions.override { vscodeExtensions = with vscode-extensions; [ skyapps.fish-vscode ];}"
...
building '/nix/store/m7l38k9n2kyvmh7k542w2hbdmgczdb5b-vscode-with-extensions-1.38.1.drv'...

[nix-shell:/home/jon/projects/nixpkgs]$ code

shows vscode with extension installed

@jonringer jonringer merged commit 5d7f899 into NixOS:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants