Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: remove symlink to kitty-deref-symlink #69815

Merged
merged 1 commit into from Sep 28, 2019
Merged

kitty: remove symlink to kitty-deref-symlink #69815

merged 1 commit into from Sep 28, 2019

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Sep 28, 2019

Motivation for this change

Symlinking to kitty-deref-symlink on macOS is no longer needed. In fact kitty-deref-symlink is now a symlink itself.
This reverts 240fce7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tex @rvolosatovs @Ma27


Sorry for not testing this with nix but after spending a couple hours trying to make nix-review compile kitty on macOS without throwing a link error, I gave up. I can't test this on Linux since the change only affects macOS.

@Luflosi
kitty: remove symlink to kitty-deref-symlink
b83221f 
Symlinking to `kitty-deref-symlink` on macOS is no longer needed. In fact `kitty-deref-symlink` is now a symlink itself.
This reverts 240fce7.
@ofborg ofborg bot requested a review from Ma27 September 28, 2019 10:48
Ma27
Ma27 approved these changes Sep 28, 2019
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built this on a darwin machine. After taking a look at the history of this change, this seems fine to me 👍

@Ma27 Ma27 merged commit 7821baa into NixOS:master Sep 28, 2019
@Luflosi Luflosi deleted the kitty-symlink branch September 28, 2019 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Luflosi @Ma27 @Janik-Haag