Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux_rpi1: fix Raspberry Pi Zero device tree file name #69917

Merged
merged 1 commit into from Oct 3, 2019

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

With the latest update to the Raspberry Pi kernel, the device tree for the Raspberry Pi Zero was renamed, but the package was not updated to account for this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @samueldr @tkerber

@lopsided98
Copy link
Contributor Author

@GrahamcOfBorg build pkgsCross.raspberryPi.linux_rpi1

@tkerber
Copy link
Member

tkerber commented Sep 28, 2019

Ah, of course. Didn't show up in testing due to it only affecting armv6l builds, which weren't tested. I did enouter the same issue in device-tree-rpi, but missed it here. Thanks!

@matthewbauer matthewbauer merged commit 7eace49 into NixOS:master Oct 3, 2019
@lopsided98 lopsided98 deleted the linux-rpi-1-dtb-rename branch October 18, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants