Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.joblib: add setuptools dependency #69946

Merged
merged 1 commit into from
Sep 29, 2019
Merged

python3Packages.joblib: add setuptools dependency #69946

merged 1 commit into from
Sep 29, 2019
+3 −2

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 29, 2019 •
edited
Loading

Motivation for this change

closes #69522

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

$ python
Python 3.7.4 (default, Jul  8 2019, 18:31:06)
[GCC 8.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import sklearn
>>>

Sorry, something went wrong.

@jonringer
python3Packages.joblib: add setuptools dependency

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
6b89d00
@jonringer jonringer requested a review from FRidh as a code owner September 29, 2019 01:50
@ofborg ofborg bot requested a review from costrouc September 29, 2019 02:16
@FRidh FRidh merged commit d564733 into NixOS:master Sep 29, 2019
@jonringer jonringer deleted the fix-joblib branch September 29, 2019 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@costrouc costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python37Packages.joblib: import error because setuptools is missing
2 participants
@jonringer @FRidh