Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytorch: fix build #69947

Merged
merged 1 commit into from
Sep 29, 2019
Merged

python3Packages.pytorch: fix build #69947

merged 1 commit into from
Sep 29, 2019
+1 −0

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 29, 2019 •
edited
Loading

Motivation for this change

closes #69604

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@jonringer jonringer requested a review from FRidh as a code owner September 29, 2019 01:51
@jonringer
python3Packages.pytorch: fix build

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
599b8a2
@jonringer jonringer changed the title python3Packages.torch: fix build python3Packages.pytorch: fix build Sep 29, 2019
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.pytorch

@ofborg ofborg bot requested review from teh and thoughtpolice September 29, 2019 02:29
@FRidh FRidh merged commit 02648a6 into NixOS:master Sep 29, 2019
@jonringer jonringer deleted the fix-pytorch branch September 29, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

@teh teh

@thoughtpolice thoughtpolice

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't build python37.pytorchWithCuda with nix-build
2 participants
@jonringer @FRidh