-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haskell updates #69886
Haskell updates #69886
Conversation
This update was generated by hackage2nix v2.15.0 from Hackage revision commercialhaskell/all-cabal-hashes@43ab240.
This update was generated by hackage2nix v2.15.0 from Hackage revision commercialhaskell/all-cabal-hashes@05d7197.
Without this change, the build fails with: ``` Warning: This package indirectly depends on multiple versions of the same package. This is very likely to cause a compile failure. package hackage-db (hackage-db-2.0.1-AliTRXEJBGFAEMpONOEnbV) requires Cabal-2.4.0.1 package hpack (hpack-0.32.0-1iJuukTWmC4EGkYhAiFeII) requires Cabal-3.0.0.0-CD1INMNwoxXIKVgcu1nec5 package distribution-nixpkgs (distribution-nixpkgs-1.3.1-82Z2DCdLAUs8Q2gjtlPLz5) requires Cabal-3.0.0.0-CD1INMNwoxXIKVgcu1nec5 package cabal2nix (cabal2nix-2.15.0) requires Cabal-3.0.0.0-CD1INMNwoxXIKVgcu1nec5 package cabal2nix (cabal2nix-2.15.0) requires Cabal-3.0.0.0-CD1INMNwoxXIKVgcu1nec5 package cabal2nix (cabal2nix-2.15.0) requires Cabal-3.0.0.0-CD1INMNwoxXIKVgcu1nec5 ```
cabal2nix: fix build
This update was generated by hackage2nix v2.15.0 from Hackage revision commercialhaskell/all-cabal-hashes@47b2f92.
`niv` used to depend on the broken `github`. The dependency was removed and `niv` builds fine.
GHCJS: Build on Hydra
niv: mark as not broken
@GrahamcOfBorg build cachix niv cabal2nix |
@GrahamcOfBorg eval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
This branch is in no shape for a merge. Some of the changes to configuration-hackage2nix.yaml
didn't even have a chance to take effect yet because the generator wasn't run since they were added.
Sure, I'd like to understand what's missing and help out. I should have opened a draft PR, but too late :) |
This update was generated by hackage2nix v2.15.0 from Hackage revision commercialhaskell/all-cabal-hashes@04348dc.
@GrahamcOfBorg build cachix niv cabal2nix |
@peti https://hydra.nixos.org/eval/1545587 looks good |
This update was generated by hackage2nix v2.15.0-1-g5325ccd from Hackage revision commercialhaskell/all-cabal-hashes@4897232.
@peti what's left? |
This update was generated by hackage2nix v2.15.0-1-g5325ccd from Hackage revision commercialhaskell/all-cabal-hashes@36c2589.
Haddock is currently broken. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a working haddock, I suppose: https://hydra.nixos.org/eval/1546016
OK. I'm going to make another release of cachix and we can merge this tomorrow. |
This update was generated by hackage2nix v2.15.0-1-g5325ccd from Hackage revision commercialhaskell/all-cabal-hashes@c3176c0.
Released, if you update the set we can fix haddock and merge. |
This update was generated by hackage2nix v2.15.0-1-g5325ccd from Hackage revision commercialhaskell/all-cabal-hashes@b51789e.
This should fix it I guess + an override. |
This update was generated by hackage2nix v2.15.0-1-g5325ccd from Hackage revision commercialhaskell/all-cabal-hashes@845035f.
@peti does the above patch look good? |
Yes, it looks good to me. I'm not sure whether other haddock packages will build properly with a version of |
@peti cool, if you can regenerate the packages I'll verify they build and we can merge. |
This update was generated by hackage2nix v2.15.0-1-g5325ccd from Hackage revision commercialhaskell/all-cabal-hashes@54d61d7.
Done. In case you are not aware of the video, https://www.youtube.com/watch?v=qX0mgtSm360 might be of interest. |
It seems to work again. Going to merge after CI passes the evaluation checks. |
I would not have merged the branch in this state. I would have liked to do more clean-up first. 😞 |
I really wanted nixpkgs master fixed, seems like the cleanup can be done on top of this work? :) |
Well, if you don't want to take my interests seriously, then I guess I'll just file that under "experience". |
@peti I've asked you (multiple times) in this PR:
You approved the PR, then said we have to fix haddock. I've shown you the diff I applied (which I simplified). So I'm quite certain I did my best to give you a chance to communicate what you'd like to do. |
That said, thanks for the video, I'll watch it. |
No description provided.