Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofi-mpd: init at 1.1.0 #69877

Merged
merged 2 commits into from Sep 30, 2019
Merged

rofi-mpd: init at 1.1.0 #69877

merged 2 commits into from Sep 30, 2019

Conversation

JakeStanger
Copy link
Contributor

Motivation for this change

Adds package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Sep 28, 2019
View reviewed changes
pkgs/applications/audio/rofi-mpd/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/rofi-mpd/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/rofi-mpd/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Sep 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (Good job! :) )
executable seems to work (wasn't able to test it fully, but author I'm sure did this :) )
leaf package

please just squash the commits into 2:

maintainers: add jakestanger
rofi-mpd: init at 1.1.0

@jonringer
Copy link
Contributor

@GrahamcOfBorg build rofi-mpd

@jonringer
Copy link
Contributor

not sure where your git-fu is right now, but for squashing I would do:

git reset HEAD~6 #dump everything into unstaged
git add  maintainers/maintainer-list.nix
git commit -m "maintainers: add jakestanger"
git add pkgs/
git commit -m "rofi-mpd: init at 1.1.0"
git push jakestanger rofi-mpd --force

see more info on contributing guideliness here

@JakeStanger
Copy link
Contributor Author

My git-fu definitely wasn't good enough to do that without your help. Thanks a lot :)

@jonringer
Copy link
Contributor

@GrahamcOfBorg build rofi-mpd

jonringer
jonringer reviewed Sep 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just now noticed these :(.

after you apply the changes I would do:

git status # ensure you only have relevant changes
git add .
git commit --amend --no-edit
git push jakestanger rofi-mpd --force

pkgs/applications/audio/rofi-mpd/default.nix Show resolved Hide resolved
pkgs/applications/audio/rofi-mpd/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Sep 29, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable seems to work
leaf package

[2 built, 1 copied (1.2 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69877
1 package were build:
rofi-mpd

I'll allow for some other reviewers to comment, but it all LGTM.

Thanks for bearing through all the reviews/corrections :)

@jonringer
Copy link
Contributor

jonringer commented Sep 29, 2019 •
edited by markuskowa

@GrahamcOfBorg build rofi-mpd

@jonringer
Copy link
Contributor

builds on linux and darwin
seems to work (needs mpd setup which is outside my expertise, but python seems to be fine)

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/69877
1 package were build:
rofi-mpd

@jonringer jonringer merged commit 0e88a0e into NixOS:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JakeStanger @jonringer @markuskowa @Janik-Haag