Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x11spice: init at 2019-08-20 #69887

Merged
merged 1 commit into from Oct 23, 2019
Merged

x11spice: init at 2019-08-20 #69887

merged 1 commit into from Oct 23, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Sep 28, 2019

Motivation for this change

SPICE is a protocol generally used for virtual machines but it's also useful as a remote desktop: it's much faster than regular VNC.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (new package)
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Comment on lines 10 to 14
domain = "gitlab.freedesktop.org";
owner = "spice";
repo = "x11spice";
rev = "51d2a8ba3813469264959bb3ba2fc6fe08097be6";
sha256 = "0va5ix14vnqch59gq8wvrhw6q0w0n27sy70xx5kvfj2cl0h1xpg8";
Copy link
Member

@Lassulus Lassulus Oct 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm personally not a big fan of this indentation style, it either creates unnecessary diff noise when adding a new attribute which is longer or it gets weird. If we now have something to automatically format things like this, I would be happy for a heads up. If you really prefer this style of indent I would also let it pass

Copy link
Contributor Author

@rnhmjoj rnhmjoj Oct 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's nothing automatic: I have been formatting like this since I started contributing in 2015, which is a habit I got from writing haskell.
Since you are the second reviewer that recently disliked it I'm just going to drop it. I'm just surprised that no one ever mentioned this before (I did around 300 PRs) if it's not generally accepted.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, started the server, connectet with a client

@Lassulus Lassulus merged commit dc00cee into NixOS:master Oct 23, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Oct 23, 2019

Thank you.

@rnhmjoj rnhmjoj deleted the x11spice branch January 8, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants