x11spice: init at 2019-08-20 #69887
x11spice: init at 2019-08-20 #69887
Conversation
ofborg
bot
added
8.has: package (new)
pkgs/tools/X11/x11spice/default.nix
Outdated
| domain = "gitlab.freedesktop.org"; | ||
| owner = "spice"; | ||
| repo = "x11spice"; | ||
| rev = "51d2a8ba3813469264959bb3ba2fc6fe08097be6"; | ||
| sha256 = "0va5ix14vnqch59gq8wvrhw6q0w0n27sy70xx5kvfj2cl0h1xpg8"; |
There was a problem hiding this comment.
I'm personally not a big fan of this indentation style, it either creates unnecessary diff noise when adding a new attribute which is longer or it gets weird. If we now have something to automatically format things like this, I would be happy for a heads up. If you really prefer this style of indent I would also let it pass
There was a problem hiding this comment.
No, it's nothing automatic: I have been formatting like this since I started contributing in 2015, which is a habit I got from writing haskell.
Since you are the second reviewer that recently disliked it I'm just going to drop it. I'm just surprised that no one ever mentioned this before (I did around 300 PRs) if it's not generally accepted.
|
Thank you. |
Motivation for this change
SPICE is a protocol generally used for virtual machines but it's also useful as a remote desktop: it's much faster than regular VNC.
Things done
nix path-info -Sbefore and after)