Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stress-ng: 0.10.02 -> 0.10.05, fix w/musl #68918

Merged
merged 2 commits into from Sep 27, 2019
Merged

stress-ng: 0.10.02 -> 0.10.05, fix w/musl #68918

merged 2 commits into from Sep 27, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Sep 16, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @c0bw3b

@ofborg ofborg bot requested a review from c0bw3b September 16, 2019 16:14
@dtzWill dtzWill force-pushed the update/stress-ng-0.10.05-musl branch from 2c14431 to 31be449 Compare September 16, 2019 17:37
@dtzWill
Copy link
Member Author

dtzWill commented Sep 16, 2019

(updated to limit sysinfo workaround to musl, as it's not needed for glibc even if safe)

@dtzWill
Copy link
Member Author

dtzWill commented Sep 16, 2019

@GrahamcOfBorg build stress-ng pkgsMusl.stress-ng

c0bw3b
c0bw3b approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and runs

@c0bw3b c0bw3b merged commit 7651937 into NixOS:master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @c0bw3b