-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mariadb-connector-c: fix socket path #70010
mariadb-connector-c: fix socket path #70010
Conversation
cc @Izorkin for informational purposes. |
@ajs124 Does this need a backport? |
No backport needed, I think. Maybe to 19.09? MariaDB packaging works quite different on 19.03. |
No need change PR to staging? |
@GrahamcOfBorg test wordpress @ajs124 I'm surprised this hasn't been merged yet... I assume without this change |
@aanderse That's the thing. No warning, no nothing. At least from what I saw. Just that the path is different in the library. I tested it with my dovecot and @mmilata seems to have run into it with his sympa PR. I'm sure there are more things out there, but most applications probably connect to MariaDB over TCP, so they won't run into this. |
I can't find a changelog entry, but this commit seems to be responsible. It's from 2016, but it seems like nixpkgs only has 3.x since August of this year. |
I do not use a socket connection. I do not know how to check. |
In source not found MYSQL_UNIX_ADDR. |
Confirming that this fixes my issue. Thanks for pinging me, yesterday I spent some time being really puzzled why it's happening without being able to trace it to this package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems straight forward enough. Merging based on feedback and detective work from all parties involved. Thanks everyone! 🎉
Motivation for this change
Fix socket path. The cmakeFlag changed from MYSQL_ to MARIADB_ some time recently.
This broke my setup.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc @thoughtpolice