elm.elmPackages: Cleanup code #70011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turboMaCk
commented
Sep 29, 2019
| hsPkgs = haskell.packages.ghc865.override { | ||
| overrides = self: super: with haskell.lib; | ||
| let elmPkgs = rec { | ||
| elm = overrideCabal (self.callPackage ./packages/elm.nix { }) (drv: { | ||
| # sadly with parallelism most of the time breaks compilation | ||
| # also compilation is slower with increasing number of cores anyway (Tested on Ryzen 7 and i7) |
There was a problem hiding this comment.
I've added this comment in past as a note for myself but forgot to remove it. I don't think it's important enough to keep it there.
domenkozar
approved these changes
Sep 29, 2019
turboMaCk
force-pushed
the
chore/cleanup-elmPackages
branch
from
4de8af1
to
0a0763d
Compare
turboMaCk
force-pushed
the
chore/cleanup-elmPackages
branch
from
0a0763d
to
48e57cf
Compare
This is ready to be merged from my side. |
|
@GrahamcOfBorg build elmPackages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be aware that this is chore so it's probably low-priority PR
Cleaning up the mess I made over several months adding elm tooling to hopefully easier to understand and more maitainable structure.
elm-livefromnodeModuleselmPackages.lib.patchBinwrapThis will need a code quality review
Is this separation of node and elm based packages what we want?
Is it ok to just remove
elm-livefrom nodePackages (maybe we should first mark it as deprecated?)Is it fine to expose
lib.patchBinwrapTested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nix-review --run "nix-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.
Notify maintainers
cc @domenkozar