Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

halide new release 2018/02/15 -> 2019/08/27 #70015

Merged
merged 2 commits into from Sep 30, 2019
Merged

halide new release 2018/02/15 -> 2019/08/27 #70015

merged 2 commits into from Sep 30, 2019

Conversation

ck3d
Copy link
Contributor

@ck3d ck3d commented Sep 29, 2019

Motivation for this change

updated to new release

Things done

compiled and run my own halide projects.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @markuskowa

@markuskowa
Copy link
Member

markuskowa commented Sep 29, 2019 •
edited

@GrahamcOfBorg eval
@GrahamcOfBorg build halide

@markuskowa
Copy link
Member

It looks like halide on aarch broke earlier (https://hydra.nixos.org/build/92862735). Would you mind taking a look?

@ckesg
Halide platforms limited to x68
8bc8184 
ARM platforms are currently not supported by Halide:

halide/Halide#3296
@ck3d
Copy link
Contributor Author

ck3d commented Sep 30, 2019

not supported by Halide

halide/Halide#3296

I updated the PR

@markuskowa markuskowa merged commit bbfd905 into NixOS:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ck3d @markuskowa @ckesg